[libvirt] [PATCH] virDomainShutdown*: Describe blocking behaviour

Eric Blake eblake at redhat.com
Tue Mar 31 12:40:53 UTC 2015


On 03/31/2015 01:37 AM, Michal Privoznik wrote:

>> I don't think this is the right approach.  It is okay to block for a
>> small finite amount of time, but if the guest agent really is something
>> that can hang, we should fix that code to return without waiting for the
>> agent response.
>>
> 
> The problem is, we can tell if the shutdown qemu-ga command succeeded
> only when we see the SHUTDOWN event on the domain monitor.

But we don't NEED to know if it succeeded - per our docs, we only issue
the request (or fail outright because the request cannot be delivered
because the agent is non-responsive).

> The other
> option is to treat it like we're treating ACPI mode of the API: just
> send the request and report if the sending succeeded. Don't wait until
> domain actually shuts down. I can provide a patch.

Yes, that would be more in line with the docs.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150331/159ac29d/attachment-0001.sig>


More information about the libvir-list mailing list