[libvirt] [PATCH] tests: Remove redundant aarch64 tests
Cole Robinson
crobinso at redhat.com
Thu May 7 15:55:59 UTC 2015
On 05/07/2015 11:48 AM, Laine Stump wrote:
> On 05/07/2015 11:30 AM, Cole Robinson wrote:
>> My commit 7b9de914 added some aarch64 CPU test cases. I wanted to test
>> two different code paths but inadvertently added two of the same test
>> cases.
>>
>> The second code path (using <cpu><model>host</model</cpu>) isn't easily
>> exercised via the qemu tests anyways, I'll need to look elsewhere.
>>
>> Regardless, remove the redundant tests for now
>> ---
>> .../qemuxml2argv-aarch64-cpu-model-host.args | 5 ----
>> .../qemuxml2argv-aarch64-cpu-model-host.xml | 28 ----------------------
>> tests/qemuxml2argvtest.c | 3 ---
>> .../qemuxml2argv-aarch64-cpu-passthrough.xml | 27 ---------------------
>> tests/qemuxml2xmltest.c | 2 --
>> 5 files changed, 65 deletions(-)
>> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.args
>> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.xml
>> delete mode 100644 tests/qemuxml2xmloutdata/qemuxml2argv-aarch64-cpu-passthrough.xml
>
> You also delete a redundant xml file in qemuxml2xmloutdata (since it's
> identical to the file in qemuxml2argvdata).
>
>
> ACK.
>
Thanks, pushed
- Cole
More information about the libvir-list
mailing list