[libvirt] [PATCH v2 3/5] storage: conf: Don't set any default <mode> in the XML

Eric Blake eblake at redhat.com
Fri May 8 15:14:22 UTC 2015

On 05/08/2015 08:24 AM, John Ferlan wrote:

> I think right about here there needs to be some logic added to avoid
> printing (since it's optional anyway):
> <permissions>
> </permissions>
> in the output XML

We may still want to output:


to make it obvious that we considered permissions, but had nothing to
say about them (as opposed to no information about it at all) - similar
to how <backingChain/> is used in <disk> elements to distinguish between
end-of-chain and no information available.

But I agree that an empty


looks weird, even though it is equally valid as XML.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150508/6e70edb9/attachment-0001.sig>

More information about the libvir-list mailing list