[libvirt] [PATCH 3/3] parallels: fix possible crash in case of errors in prlsdkLoadDomain
Daniel P. Berrange
berrange at redhat.com
Wed May 20 12:32:28 UTC 2015
On Mon, May 18, 2015 at 05:44:20PM +0300, Maxim Nestratov wrote:
> Cleanup code in prlsdkLoadDomain doesn't take into account the fact
> if private domain freeing function is assigned or not. In case it is,
> we shouldn't call it manually because virDomainObjListRemove calls it.
> Also, allocated def structure should be freed only if it's not
> assigned to domain. Otherwise it will be called twice one time by
> virDomainObjListRemove and the second by prlsdkLoadDomain itself.
> Signed-off-by: Maxim Nestratov <mnestratov at parallels.com>
> src/parallels/parallels_sdk.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
ACK, but will let Dmitry sanity check and push this series too.
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list