[libvirt] [PATCH v2 2/5] storage: conf: Don't output owner/group -1
Cole Robinson
crobinso at redhat.com
Thu May 21 19:04:22 UTC 2015
On 05/08/2015 10:04 AM, John Ferlan wrote:
>
>
> On 05/05/2015 12:44 PM, Cole Robinson wrote:
>> -1 is just an internal placeholder and is meaningless to output in the XML.
>> ---
>> docs/schemas/storagecommon.rng | 28 ++++++++++++----------
>> src/conf/storage_conf.c | 23 +++++++++++-------
>> tests/storagepoolxml2xmlout/pool-dir-naming.xml | 2 --
>> tests/storagepoolxml2xmlout/pool-dir.xml | 2 --
>> tests/storagepoolxml2xmlout/pool-netfs-gluster.xml | 2 --
>> .../vol-gluster-dir-neg-uid.xml | 2 --
>> tests/storagevolxml2xmlout/vol-gluster-dir.xml | 2 --
>> tests/storagevolxml2xmlout/vol-sheepdog.xml | 2 --
>> 8 files changed, 30 insertions(+), 33 deletions(-)
>>
>
> Might be nice to update formatstorage.html.in to indicate that the
> <owner> && <group> are optional and if not provided the pool/volume will
> take the owner/group of the parent directory
>
>
> ACK -
>
Thanks, pushed now. I'll send the docs patch separately since it's a
pre-existing issue
- Cole
More information about the libvir-list
mailing list