[libvirt] [PATCH 19/35] lib: virDomainPinIOThread: Remove spurious overflow check

Peter Krempa pkrempa at redhat.com
Fri May 29 13:33:40 UTC 2015


Internal structures use unsigned int, so there's no need for this legacy
check that was copied from the vCPU pinning api.
---
 src/libvirt-domain.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 05990c7..7e6d749 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -7906,11 +7906,6 @@ virDomainPinIOThread(virDomainPtr domain,
     conn = domain->conn;

     virCheckReadOnlyGoto(conn->flags, error);
-    if ((unsigned short) iothread_id != iothread_id) {
-        virReportError(VIR_ERR_OVERFLOW, _("input too large: %u"),
-                       iothread_id);
-        goto error;
-    }
     virCheckPositiveArgGoto(iothread_id, error);
     virCheckNonNullArgGoto(cpumap, error);
     virCheckPositiveArgGoto(maplen, error);
-- 
2.4.1




More information about the libvir-list mailing list