[libvirt] [PATCH 22/35] libxl: Don't remove vcpu pin definition in libxlDomainCleanup

Peter Krempa pkrempa at redhat.com
Fri May 29 13:33:43 UTC 2015


The vCPU pinning definition gets removed when the domain definition is
being freed later. If there is no next configuration it would remove the
configured pinning.
---
 src/libxl/libxl_domain.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 632e5aa..592b80e 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -690,7 +690,6 @@ libxlDomainCleanup(libxlDriverPrivatePtr driver,
     libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
     int vnc_port;
     char *file;
-    size_t i;
     virHostdevManagerPtr hostdev_mgr = driver->hostdevMgr;

     virHostdevReAttachDomainDevices(hostdev_mgr, LIBXL_DRIVER_NAME,
@@ -725,16 +724,6 @@ libxlDomainCleanup(libxlDriverPrivatePtr driver,
         }
     }

-    /* Remove any cputune settings */
-    if (vm->def->cputune.nvcpupin) {
-        for (i = 0; i < vm->def->cputune.nvcpupin; ++i) {
-            virBitmapFree(vm->def->cputune.vcpupin[i]->cpumask);
-            VIR_FREE(vm->def->cputune.vcpupin[i]);
-        }
-        VIR_FREE(vm->def->cputune.vcpupin);
-        vm->def->cputune.nvcpupin = 0;
-    }
-
     if (virAsprintf(&file, "%s/%s.xml", cfg->stateDir, vm->def->name) > 0) {
         if (unlink(file) < 0 && errno != ENOENT && errno != ENOTDIR)
             VIR_DEBUG("Failed to remove domain XML for %s", vm->def->name);
-- 
2.4.1




More information about the libvir-list mailing list