Re: [libvirt] [PATCH v2 0/2] Introduce GIC for aarch64

[John Ferlan <jferlan redhat com>]

On 05/04/2015 08:09 AM, Michal Privoznik wrote:
> diff to v1:
> - John's review worked in (hopefully)
> 
> Michal Privoznik (2):
>   Introduce GIC feature
>   qemu: Implement GIC
> 
>  docs/formatdomain.html.in                          | 10 ++++++
>  docs/schemas/domaincommon.rng                      | 11 ++++++-
>  src/conf/domain_conf.c                             | 37 +++++++++++++++++++++-
>  src/conf/domain_conf.h                             |  2 ++
>  src/qemu/qemu_command.c                            | 13 ++++++++
>  .../qemuxml2argvdata/qemuxml2argv-aarch64-gic.args |  6 ++++
>  .../qemuxml2argvdata/qemuxml2argv-aarch64-gic.xml  | 26 +++++++++++++++
>  tests/qemuxml2argvtest.c                           |  2 ++
>  8 files changed, 105 insertions(+), 2 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic.xml
> 


As long as you remove the comment in domain_conf.h:

+    unsigned int gic_version; /* by default 2 */


ACK series


John