[libvirt] [PATCH 1/2] virSysinfoParseProcessor: Drop useless check for NULL

Michal Privoznik mprivozn at redhat.com
Tue May 12 16:23:55 UTC 2015


VIR_STRDUP plays nicely with NULLs. Theres no need to guard its
call with check for non-NULL.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/util/virsysinfo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c
index 4edce66..8bb17f0 100644
--- a/src/util/virsysinfo.c
+++ b/src/util/virsysinfo.c
@@ -315,8 +315,7 @@ virSysinfoParseProcessor(const char *base, virSysinfoDefPtr ret)
                         cur, eol - cur) < 0)
             goto error;
 
-        if (processor_type &&
-            VIR_STRDUP(processor->processor_type, processor_type) < 0)
+        if (VIR_STRDUP(processor->processor_type, processor_type) < 0)
             goto error;
 
         base = cur;
-- 
2.3.6




More information about the libvir-list mailing list