Re: [libvirt] [PATCH v3 3/4] qemuDomainAttachChrDevice: Fix chardev hotplug

["Daniel P. Berrange" <berrange redhat com>]

On Thu, May 14, 2015 at 10:33:05AM +0200, Michal Privoznik wrote:
> Not every chardev is plugged onto virtio-serial bus. However, the
> code introduced in 89e991a2aa36b04 assumes that. Incorrectly.
> With previous patches we have three options where a chardev can
> be plugged: virtio-serial, USB and PCI. This commit fixes the
> attach part.  However, since we are not auto allocating USB
> addresses yet, I'm just marking the place where appropriate code
> should go.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/qemu/qemu_hotplug.c | 28 +++++++++++++++++++++-------
>  1 file changed, 21 insertions(+), 7 deletions(-)

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|