[libvirt] [PATCH] virsh: reject negative values for scaled integer
Pavel Hrdina
phrdina at redhat.com
Mon May 25 07:12:48 UTC 2015
On Fri, May 22, 2015 at 01:07:31PM -0600, Eric Blake wrote:
> On 05/22/2015 08:01 AM, Pavel Hrdina wrote:
> > Some virsh commands have a size parameter, which is handled as scaled
> > integer. We don't have any *feature* that would allow to use '-1' as
> > maximum size, so it's safe to reject any negative values for those
> > commands.
> >
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1159171
> >
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> > tools/virsh.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> ACK, particularly since it gets hard to justify whether -1M and -1G
> would mean the same "maximum size".
Thanks, pushed now.
Pavel
More information about the libvir-list
mailing list