[libvirt] [PATCH] lxc: properly clean up qemu-nbd

Martin Kletzander mkletzan at redhat.com
Thu May 28 10:05:15 UTC 2015


On Wed, May 27, 2015 at 10:56:06AM +0200, Cédric Bosdonnat wrote:
>Add the qemu-nbd tasks to the container cgroup to make sure those will
>be killed when the container is stopped. In order to reliably get the
>qemu-nbd tasks PIDs, we use /sys/devices/virtual/block/<DEV>/pid as
>qemu-nbd is daemonizing itself.
>---
> src/libvirt_private.syms |  1 +
> src/lxc/lxc_controller.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++
> src/util/virprocess.c    | 45 ++++++++++++++++++++++++++++++++++++++
> src/util/virprocess.h    |  2 ++
> 4 files changed, 104 insertions(+)
>

I'd rather see this split into at least two patches, it's easier to
review the addition of the new function by itself and the rest apart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150528/01d0be3e/attachment-0001.sig>


More information about the libvir-list mailing list