[libvirt] [PATCH] qemu: fix forget pass the return value to variable @ret

Luyao Huang lhuang at redhat.com
Sun May 31 13:27:25 UTC 2015


If we do not pass the return value from qemuDomainRemoveRNGDevice()
function to variable @ret, qemuDomainRemoveDevice() functiuon will
always fail when recive rng device unplug event from qemu monitor.

Signed-off-by: Luyao Huang <lhuang at redhat.com>
---
 src/qemu/qemu_hotplug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 170768b..f596730 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -3271,7 +3271,7 @@ qemuDomainRemoveDevice(virQEMUDriverPtr driver,
         ret = qemuDomainRemoveChrDevice(driver, vm, dev->data.chr);
         break;
     case VIR_DOMAIN_DEVICE_RNG:
-        qemuDomainRemoveRNGDevice(driver, vm, dev->data.rng);
+        ret = qemuDomainRemoveRNGDevice(driver, vm, dev->data.rng);
         break;
 
     case VIR_DOMAIN_DEVICE_MEMORY:
-- 
1.8.3.1




More information about the libvir-list mailing list