[libvirt] [PATCH v2 6/9] Split reprobe action from the virPCIUnbindFromStub into a new function

Peter Krempa pkrempa at redhat.com
Mon Nov 2 09:08:28 UTC 2015


On Mon, Nov 02, 2015 at 03:23:26 +0530, Shivaprasad G Bhat wrote:
> The reprobe needs to be called multiple times for vfio devices for each
> device in the iommu group in future patch. So split the reprobe into a
> new function. No functional change.
> 
> Signed-off-by: Shivaprasad G Bhat <sbhat at linux.vnet.ibm.com>
> ---
>  src/util/virpci.c |   44 ++++++++++++++++++++++++++++----------------
>  1 file changed, 28 insertions(+), 16 deletions(-)
> 
> diff --git a/src/util/virpci.c b/src/util/virpci.c
> index f401e1d..77ae455 100644
> --- a/src/util/virpci.c
> +++ b/src/util/virpci.c
> @@ -1098,6 +1098,33 @@ virPCIIsAKnownStub(char *driver)
>      return ret;
>  }
>  
> +static int virPCIDeviceReprobeHostDriver(virPCIDevicePtr dev, char *driver, char *drvdir)

Please format the header the same way as other headers are formatted in
this file.

> +{
> +    char *path = NULL;
> +    int result = -1;

We usually use 'ret' for this kind of variable.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151102/4a4b62bf/attachment-0001.sig>


More information about the libvir-list mailing list