[libvirt] [PATCH] syntax-check: Add sc_prohibit_space_in_label rule

[Peter Krempa]

On Mon, Nov 02, 2015 at 10:34:35 +0100, Andrea Bolognani wrote:
> This guards against code such as
> 
>  cleanup :
> 
> which is happily accepted by the compiler but does not conform
> to our style guidelines.
> ---
>  cfg.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/cfg.mk b/cfg.mk
> index a9bba38..8462051 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -919,6 +919,12 @@ sc_require_space_before_label:
>  	halt="Top-level labels should be indented by one space"        \
>  	  $(_sc_search_regexp)
>  
> +sc_prohibit_space_in_label:
> +	@prohibit='^[_a-zA-Z0-9]+ +:$$'                                \

Our labels enforce at least one space before a label so I don't think
this will work. If you will be adding a multi-space match, please make
sure that "case" is not matched in that case.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151102/fd5ceacb/attachment-0001.sig>