[libvirt] [PATCH] virkeymaps.h: Fix VPATH build with --disable-dependency-tracking

Michal Privoznik mprivozn at redhat.com
Tue Nov 3 08:08:04 UTC 2015

Funny things happen when you try to do a VPATH build and pass
--disable-dependency-tracking argument to the configure script.
Not only the directory structure is not created at the end of
configure phase, but also contradictory to others, virkeymaps.h
does not depend on src/utils dirstamp. I don't know how to force
automake to generate that rule, but this is the diff that makes
things work for me again. Yes, as you can see it more or less
reverts a9fe620372144db3e432bd7506cb909cc3179ef8. More than less.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Steps to reproduce:

1) mkdir /tmp/test_libvirt && cd $_
2) $OLDPWD/configure --disable-dependency-tracking
3) make

 src/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 99b4993..f98912f 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -181,7 +181,7 @@ MAINTAINERCLEANFILES += util/virkeymaps.h
 util/virkeymaps.h: $(srcdir)/util/keymaps.csv	\
 	$(AM_V_GEN)$(PYTHON) $(srcdir)/util/virkeycode-mapgen.py \
-	  <$(srcdir)/util/keymaps.csv >util/virkeymaps.h
+	  <$(srcdir)/util/keymaps.csv >$(srcdir)/util/virkeymaps.h
 # Internal generic driver infrastructure
 NODE_INFO_SOURCES = nodeinfo.h nodeinfo.c nodeinfopriv.h

More information about the libvir-list mailing list