[libvirt] [PATCH] virkeymaps.h: Fix VPATH build with --disable-dependency-tracking

[Martin Kletzander]

On Tue, Nov 03, 2015 at 10:55:31AM +0100, Peter Krempa wrote:
>On Tue, Nov 03, 2015 at 10:40:50 +0100, Peter Krempa wrote:
>> On Tue, Nov 03, 2015 at 09:08:04 +0100, Michal Privoznik wrote:
>> > Funny things happen when you try to do a VPATH build and pass
>> > --disable-dependency-tracking argument to the configure script.
>> > Not only the directory structure is not created at the end of
>> > configure phase, but also contradictory to others, virkeymaps.h
>>
>> Maybe that's the actual problem.
>>
>
>[...]
>
>> >
>> >  src/Makefile.am | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/src/Makefile.am b/src/Makefile.am
>> > index 99b4993..f98912f 100644
>> > --- a/src/Makefile.am
>> > +++ b/src/Makefile.am
>> > @@ -181,7 +181,7 @@ MAINTAINERCLEANFILES += util/virkeymaps.h
>> >  util/virkeymaps.h: $(srcdir)/util/keymaps.csv	\
>> >  		$(srcdir)/util/virkeycode-mapgen.py
>> >  	$(AM_V_GEN)$(PYTHON) $(srcdir)/util/virkeycode-mapgen.py \
>> > -	  <$(srcdir)/util/keymaps.csv >util/virkeymaps.h
>> > +	  <$(srcdir)/util/keymaps.csv >$(srcdir)/util/virkeymaps.h
>
>A proper fix will be something along:
>
>diff --git a/src/Makefile.am b/src/Makefile.am
>index 99b4993..db0ca54 100644
>--- a/src/Makefile.am
>+++ b/src/Makefile.am
>@@ -1056,6 +1056,7 @@ libvirt_util_la_LIBADD = $(CAPNG_LIBS) $(YAJL_LIBS) $(LIBNL_LIBS) \
>                $(LIB_CLOCK_GETTIME) $(DBUS_LIBS) $(MSCOM_LIBS) $(LIBXML_LIBS) \
>                $(SECDRIVER_LIBS) $(NUMACTL_LIBS) $(SYSTEMD_DAEMON_LIBS) \
>                $(POLKIT_LIBS)
>+libvirt_util_DEPENDENCIES = util/keymaps.h
>

Do you mean libvirt_util_la_DEPENDECIES?  Why wouldn't it be in the
dependencies when it is in the SOURCES?  Although if that works for
you, then I'm OK with that as well.

Anyway, I don't see how that would create the directory in builddir.
As I already said, I am OK with both reverting my patch that moves the
generated file from srcdir to builddir (which is the right thing to
do, but we generate *so* much stuff into srcdir already that it
doesn't make much sense unless it's all fixed together), or just
putting '$(MKDIR_P) util/' before the generation of virkeymaps.h.
That fixes it as well.

>
> noinst_LTLIBRARIES += libvirt_conf.la
>
>That fixes the symptom for me.
>
>Peter
>



>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151103/8d83efae/attachment-0001.sig>