[libvirt] [PATCH] bhyve: add bootrom support

[Roman Bogorodskiy]

  Roman Bogorodskiy wrote:

>   Daniel P. Berrange wrote:
> 
> > On Mon, Nov 02, 2015 at 04:24:09PM +0300, Roman Bogorodskiy wrote:
> > > Recently, bhyve got UEFI support that eliminates necessity of
> > > having two-step process of starting a VM, i.e. loading OS
> > > using loader like bhyveloader or grub and then calling bhyve itself.
> > > 
> > > From user perspective usage looks the following: if a domain XML
> > > contains the '<bootloader>' element and it's value is a path
> > > to non-executable file, then it's treated as a path to bootrom
> > > file and external loader is not execute.
> > 
> > Actually, <bootloader> is used to signify a helper program that
> > runs in host context to acquire a kernel + initrd image to boot
> > a guest from. So that's not the right element to be using here
> > 
> > If you want to provide a guest BIOS image, then you want to use
> > the <loader> element instead. IIUC, for UEFI, we use this with
> > QEMU/KVM:
> > 
> >   <loader readonly='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.fd</loader>
> 
> Ah, I should read formatdomain.html more carefully!
> 
> I'll work on v2, thanks for the feedback.

JFI, yesterday I was giving more testing for this feature and spotted
some weird issue:

https://lists.freebsd.org/pipermail/freebsd-virtualization/2015-November/003904.html

I'm not sure how critical and general it is, I'll hold this patch until
I figure out.

Roman Bogorodskiy