[libvirt] [PATCH 4/5] logging: add client for virtlogd daemon
Daniel P. Berrange
berrange at redhat.com
Tue Nov 3 16:04:23 UTC 2015
Add the virLogManager API which allows for communication with
the virtlogd daemon to RPC program. This provides the client
side API to open log files for guest domains.
The virtlogd daemon is setup to auto-spawn on first use when
running unprivileged. For privileged usage, systemd socket
activation is used instead.
Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
po/POTFILES.in | 1 +
src/Makefile.am | 4 +-
src/libvirt_private.syms | 6 ++
src/logging/log_manager.c | 197 ++++++++++++++++++++++++++++++++++++++++++++++
src/logging/log_manager.h | 42 ++++++++++
5 files changed, 249 insertions(+), 1 deletion(-)
create mode 100644 src/logging/log_manager.c
create mode 100644 src/logging/log_manager.h
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 55baaae..91b88cb 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -81,6 +81,7 @@ src/locking/sanlock_helper.c
src/logging/log_daemon.c
src/logging/log_daemon_config.c
src/logging/log_handler.c
+src/logging/log_manager.c
src/lxc/lxc_cgroup.c
src/lxc/lxc_fuse.c
src/lxc/lxc_hostdev.c
diff --git a/src/Makefile.am b/src/Makefile.am
index b305cab..aef4851 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -216,7 +216,9 @@ DRIVER_SOURCES = \
locking/lock_manager.c locking/lock_manager.h \
locking/lock_driver.h \
locking/lock_driver_nop.h locking/lock_driver_nop.c \
- locking/domain_lock.h locking/domain_lock.c
+ locking/domain_lock.h locking/domain_lock.c \
+ logging/log_manager.c logging/log_manager.h \
+ $(NULL)
LOCK_DRIVER_SANLOCK_SOURCES = \
locking/lock_driver_sanlock.c
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index ff4b0e4..3d8e352 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1003,6 +1003,12 @@ virLockManagerPluginUsesState;
virLockManagerRelease;
+# logging/log_manager.h
+virLogManagerNew;
+virLogManagerFree;
+virLogManagerDomainWriteLogFile;
+
+
# nodeinfo.h
nodeAllocPages;
nodeCapsInitNUMA;
diff --git a/src/logging/log_manager.c b/src/logging/log_manager.c
new file mode 100644
index 0000000..d9d9497
--- /dev/null
+++ b/src/logging/log_manager.c
@@ -0,0 +1,197 @@
+/*
+ * log_manager.c: log management client
+ *
+ * Copyright (C) 2015 Red Hat, Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Author: Daniel P. Berrange <berrange at redhat.com>
+ */
+
+#include <config.h>
+
+#include "configmake.h"
+
+#include "log_manager.h"
+#include "log_protocol.h"
+#include "viralloc.h"
+#include "virutil.h"
+#include "virstring.h"
+#include "virerror.h"
+#include "virfile.h"
+
+#include "rpc/virnetclient.h"
+
+#define VIR_FROM_THIS VIR_FROM_LOGGING
+
+struct _virLogManager {
+ virNetClientPtr client;
+ virNetClientProgramPtr program;
+ unsigned int serial;
+};
+
+
+static char *virLogManagerDaemonPath(bool privileged)
+{
+ char *path;
+ if (privileged) {
+ if (VIR_STRDUP(path, LOCALSTATEDIR "/run/libvirt/virtlogd-sock") < 0)
+ return NULL;
+ } else {
+ char *rundir = NULL;
+
+ if (!(rundir = virGetUserRuntimeDirectory()))
+ return NULL;
+
+ if (virAsprintf(&path, "%s/virtlogd-sock", rundir) < 0) {
+ VIR_FREE(rundir);
+ return NULL;
+ }
+
+ }
+ return path;
+}
+
+
+static virNetClientPtr
+virLogManagerConnect(bool privileged,
+ virNetClientProgramPtr *prog)
+{
+ virNetClientPtr client = NULL;
+ char *logdpath;
+ char *daemonPath = NULL;
+
+ *prog = NULL;
+
+ if (!(logdpath = virLogManagerDaemonPath(privileged)))
+ goto error;
+
+ if (!privileged &&
+ !(daemonPath = virFileFindResourceFull("virtlogd",
+ NULL, NULL,
+ abs_topbuilddir "/src",
+ SBINDIR,
+ "VIRTLOGD_PATH")))
+ goto error;
+
+ if (!(client = virNetClientNewUNIX(logdpath,
+ daemonPath != NULL,
+ daemonPath)))
+ goto error;
+
+ if (!(*prog = virNetClientProgramNew(VIR_LOG_MANAGER_PROTOCOL_PROGRAM,
+ VIR_LOG_MANAGER_PROTOCOL_PROGRAM_VERSION,
+ NULL,
+ 0,
+ NULL)))
+ goto error;
+
+ if (virNetClientAddProgram(client, *prog) < 0)
+ goto error;
+
+ VIR_FREE(daemonPath);
+ VIR_FREE(logdpath);
+
+ return client;
+
+ error:
+ VIR_FREE(daemonPath);
+ VIR_FREE(logdpath);
+ virNetClientClose(client);
+ virObjectUnref(client);
+ virObjectUnref(*prog);
+ return NULL;
+}
+
+
+virLogManagerPtr virLogManagerNew(bool privileged)
+{
+ virLogManagerPtr mgr;
+
+ if (VIR_ALLOC(mgr) < 0)
+ goto error;
+
+ if (!(mgr->client = virLogManagerConnect(privileged, &mgr->program)))
+ goto error;
+
+ return mgr;
+
+ error:
+ virLogManagerFree(mgr);
+ return NULL;
+}
+
+
+void virLogManagerFree(virLogManagerPtr mgr)
+{
+ if (!mgr)
+ return;
+
+ if (mgr->client)
+ virNetClientClose(mgr->client);
+ virObjectUnref(mgr->client);
+
+ VIR_FREE(mgr);
+}
+
+
+int virLogManagerDomainOpenLogFile(virLogManagerPtr mgr,
+ const char *driver,
+ const unsigned char *domuuid,
+ const char *domname,
+ unsigned int flags)
+{
+ struct virLogManagerProtocolDomainOpenLogFileArgs args;
+ int *fdout = NULL;
+ size_t fdoutlen = 0;
+ int ret = -1;
+
+ memset(&args, 0, sizeof(args));
+
+ args.driver = (char *)driver;
+ memcpy(args.dom.uuid, domuuid, VIR_UUID_BUFLEN);
+ args.dom.name = (char *)domname;
+ args.flags = flags;
+
+ if (virNetClientProgramCall(mgr->program,
+ mgr->client,
+ mgr->serial++,
+ VIR_LOG_MANAGER_PROTOCOL_PROC_DOMAIN_OPEN_LOG_FILE,
+ 0, NULL, &fdoutlen, &fdout,
+ (xdrproc_t)xdr_virLogManagerProtocolDomainOpenLogFileArgs, &args,
+ (xdrproc_t)xdr_void, NULL) < 0)
+ goto cleanup;
+
+ if (fdoutlen != 1) {
+ if (fdoutlen) {
+ virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+ _("too many file descriptors received"));
+ } else {
+ virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+ _("no file descriptor received"));
+ }
+ goto cleanup;
+ }
+
+ ret = fdout[0];
+ cleanup:
+ if (ret < 0) {
+ while (fdoutlen)
+ VIR_FORCE_CLOSE(fdout[--fdoutlen]);
+ }
+ VIR_FREE(fdout);
+
+ return ret;
+}
diff --git a/src/logging/log_manager.h b/src/logging/log_manager.h
new file mode 100644
index 0000000..1403547
--- /dev/null
+++ b/src/logging/log_manager.h
@@ -0,0 +1,42 @@
+/*
+ * log_manager.h: log management client
+ *
+ * Copyright (C) 2015 Red Hat, Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Author: Daniel P. Berrange <berrange at redhat.com>
+ */
+
+
+#ifndef __VIR_LOG_MANAGER_H__
+# define __VIR_LOG_MANAGER_H__
+
+# include "internal.h"
+
+typedef struct _virLogManager virLogManager;
+typedef virLogManager *virLogManagerPtr;
+
+virLogManagerPtr virLogManagerNew(bool privileged);
+
+void virLogManagerFree(virLogManagerPtr mgr);
+
+int virLogManagerDomainOpenLogFile(virLogManagerPtr mgr,
+ const char *driver,
+ const unsigned char *domuuid,
+ const char *domname,
+ unsigned int flags);
+
+#endif /* __VIR_LOG_MANAGER_H__ */
--
2.5.0
More information about the libvir-list
mailing list