[libvirt] [PATCH 0/3] Alternative proposal to revert the removal of logging of errors from virNetDevSendEthtoolIoctl

John Ferlan jferlan at redhat.com
Wed Nov 4 00:18:08 UTC 2015

Rather than revert as proposed here:


Let's make some adjustments to the existing algorithm.

The only question I don't have answered in my mind is whether an
unprivileged daemon that has an interface with the feature bits
defined should be allowed to start. Historically we haven't stopped
it, so doing so now may not be right/good. Conversely, someone may
"believe" their bits are set on their device when in fact they are
not. Of course it's not documented on formatnode.html that setting
the feature bits requires root. I did find through various searches
that SIOCETHTOOL doesn't work unless it's run under root.

John Ferlan (3):
  virnetdev: Check correct return value for virNetDevFeatureAvailable
  virnetdev: Message in virNetDevSendEthtoolIoctl rather than caller.
  virnetdev: Add check for unprivileged daemon

 src/util/virnetdev.c | 38 ++++++++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 14 deletions(-)


More information about the libvir-list mailing list