[libvirt] [PATCH 1/4] storage: Make active boolean

John Ferlan jferlan at redhat.com
Wed Nov 4 21:58:46 UTC 2015


Since we treat it like a boolean, let's store it that way. At least one
path had already treated as true/false anyway.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/conf/storage_conf.h      |  2 +-
 src/storage/storage_driver.c | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
index 7471006..ec59c17 100644
--- a/src/conf/storage_conf.h
+++ b/src/conf/storage_conf.h
@@ -266,7 +266,7 @@ struct _virStoragePoolObj {
 
     char *configFile;
     char *autostartLink;
-    int active;
+    bool active;
     int autostart;
     unsigned int asyncjobs;
 
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index ee8b263..aeb67a7 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -205,7 +205,7 @@ storageDriverAutostart(void)
                 virStoragePoolObjUnlock(pool);
                 continue;
             }
-            pool->active = 1;
+            pool->active = true;
         }
         virStoragePoolObjUnlock(pool);
     }
@@ -715,7 +715,7 @@ storagePoolCreateXML(virConnectPtr conn,
         goto cleanup;
     }
     VIR_INFO("Creating storage pool '%s'", pool->def->name);
-    pool->active = 1;
+    pool->active = true;
 
     ret = virGetStoragePool(conn, pool->def->name, pool->def->uuid,
                             NULL, NULL);
@@ -881,7 +881,7 @@ storagePoolCreate(virStoragePoolPtr obj,
         goto cleanup;
     }
 
-    pool->active = 1;
+    pool->active = true;
     ret = 0;
 
  cleanup:
@@ -978,7 +978,7 @@ storagePoolDestroy(virStoragePoolPtr obj)
 
     virStoragePoolObjClearVols(pool);
 
-    pool->active = 0;
+    pool->active = false;
 
     if (pool->configFile == NULL) {
         virStoragePoolObjRemove(&driver->pools, pool);
@@ -1100,7 +1100,7 @@ storagePoolRefresh(virStoragePoolPtr obj,
         if (backend->stopPool)
             backend->stopPool(obj->conn, pool);
 
-        pool->active = 0;
+        pool->active = false;
 
         if (pool->configFile == NULL) {
             virStoragePoolObjRemove(&driver->pools, pool);
-- 
2.1.0




More information about the libvir-list mailing list