[libvirt] [PATCH] network: Remove extraneous ATTRIBUTE_NONNULL for virNetDevWaitDadFinish

John Ferlan jferlan at redhat.com
Wed Nov 4 22:52:25 UTC 2015


Commit id '0f7436ca' added virNetDevWaitDadFinish using ATTRIBUTE_NONNULL
for both arguments, although one is a non-null argument. A Coverity build
balks at that.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---

 Pushing under the build-breaker rule

 src/util/virnetdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h
index 9108be6..772ae75 100644
--- a/src/util/virnetdev.h
+++ b/src/util/virnetdev.h
@@ -106,7 +106,7 @@ int virNetDevClearIPAddress(const char *ifname,
 int virNetDevGetIPAddress(const char *ifname, virSocketAddrPtr addr)
     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
 int virNetDevWaitDadFinish(virSocketAddrPtr *addrs, size_t count)
-    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
+    ATTRIBUTE_NONNULL(1);
 
 
 int virNetDevSetMAC(const char *ifname,
-- 
2.1.0




More information about the libvir-list mailing list