[libvirt] [PATCH 2/5] virnetdev: Document reasons for ignoring some SIOCETHTOOL errno values

John Ferlan jferlan at redhat.com
Fri Nov 6 16:39:28 UTC 2015

Recently reverted commit id '6f2a0198' showed a need to add extra
comments when dealing with filtering of potential "non-issues".

Scanning through upstream patch postings indicates early on the
reasons for the filtering of specific ioctl failures were provided;
however, when converted from causing an error to VIR_DEBUG's the
reasons were missing. A future read/change of the code incorrectly
assumed they could or should be removed.

Signed-off-by: John Ferlan <jferlan at redhat.com>
 src/util/virnetdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 971e24d..3bd7dbb 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -3166,13 +3166,13 @@ virNetDevSendEthtoolIoctl(const char *ifname, void *cmd)
     ret = ioctl(sock, SIOCETHTOOL, &ifr);
     if (ret != 0) {
         switch (errno) {
-            case EPERM:
+            case EPERM: /* attempt to call SIOCETHTOOL from unprivileged code */
                 VIR_DEBUG("ethtool ioctl: permission denied");
-            case EINVAL:
+            case EINVAL: /* kernel doesn't support SIOCETHTOOL */
                 VIR_DEBUG("ethtool ioctl: invalid request");
-            case EOPNOTSUPP:
+            case EOPNOTSUPP: /* kernel doesn't support specific feature */
                 VIR_DEBUG("ethtool ioctl: request not supported");

More information about the libvir-list mailing list