[libvirt] [PATCH v2 08/17] qemu: assume -drive argument is always available

John Ferlan jferlan at redhat.com
Mon Nov 9 23:24:07 UTC 2015

On 11/09/2015 11:24 AM, Daniel P. Berrange wrote:
> As of QEMU 0.9.1 the -drive argument can be used to configure
> all disks, so the QEMU driver can assume it is always available
> and drop support for -hda/-cdrom/etc.

As I found out (and provided some details in patch 17) - the
qemuParseCommandLine should probably fail when -hd, -sd, -fd, -cdrom are
found... Since we won't be able to parse or create xml for them. It'll
make sense later, but think about parsing "-sdl" and what happens..

> Many of the tests need updating because a great many were
> running without CAPS_DRIVE set, so using the -hda legacy
> syntax.
> Fixing the tests uncovered a bug in the argv -> xml
> convertor which failed to handle disk with if=floppy.
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---


More information about the libvir-list mailing list