[libvirt] [PATCHv3 0/4] Hyper-v crash feature support

Jiri Denemark jdenemar at redhat.com
Fri Nov 13 09:12:38 UTC 2015

On Fri, Nov 13, 2015 at 11:30:30 +0300, Dmitry Andreev wrote:
> A new Hyper-V cpu feature 'hv_crash' was added to QEMU. The feature
> will become available in v2.5.0. 
> This patch adds support for this feature.
> The previous version of this patch is  
> https://www.redhat.com/archives/libvir-list/2015-November/msg00400.html
> What is changed:
>  * 'model' is an optional attribute and will not be added
>    if it wasn't specified by the user [1/4]

Ouch, there seems to be a misunderstanding here. I didn't want you to
stop updating the model if it wasn't specified. The reason for adding a
"default" model is:

- XML parser takes the XML and leaves model as "default" in case it
  wasn't specified in the XML
- post parse callback in qemu driver changes the default panic model to
  the right one (isa or pseries); we'd also need to check we don't have
  multiple panic devices with the same model
- XML formatter only prints model if it is not default (won't happen
  with qemu driver, of course)

>  * docs text fixed [1/4] [3/4] 
>  * schema and code allows multiple panic devices [3/4]
>  * more tests is added and all changes in old tests
>    are removed [4/4] 
> What isn't changed:
> I didn't add <code> tag around model values in docs because there
> are many examples of "<ul><li> 'value' —" without a <code> tag.

Fair enough.


More information about the libvir-list mailing list