[libvirt] [PATCH 17/24] qemu: Close logfd when closing monitor

Peter Krempa pkrempa at redhat.com
Fri Nov 13 13:07:42 UTC 2015


On Thu, Nov 12, 2015 at 19:37:19 +0100, Jiri Denemark wrote:
> Remembering to call qemuMonitorSetDomainLog in the right paths before
> calling qemuProcessStop is annoying and easy to forget. And I already
> forget to do so in commit v1.2.8-52-g0389060: logfd may be leaked if

forgot

> QEMU process dies between Prepare and Finish migration phases.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_monitor.c | 2 ++
>  src/qemu/qemu_process.c | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151113/0f12d990/attachment-0001.sig>


More information about the libvir-list mailing list