[libvirt] [PATCH 20/24] qemu: Introduce qemuProcessFinish

[Peter Krempa]

On Thu, Nov 12, 2015 at 19:37:22 +0100, Jiri Denemark wrote:
> Finishes starting a new domain launched by qemuProcessLaunch.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_process.c | 76 +++++++++++++++++++++++++++++++++----------------
>  src/qemu/qemu_process.h |  6 ++++
>  2 files changed, 57 insertions(+), 25 deletions(-)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index 0314c4a..38c4eeb 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -5053,6 +5053,52 @@ qemuProcessLaunch(virConnectPtr conn,
>  }
>  
>  
> +/**
> + * qemuProcessFinish:

The name is misleading. I'd go for qemuProcessFinishStartup or something
along that to emphasize that this is tied to the startup operation.

> + *
> + * Finish starting a new domain.
> + */
> +int
> +qemuProcessFinish(virConnectPtr conn,

I'm leaned towards insisting on a name change. ACK to the code though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151113/647cfd7a/attachment-0001.sig>