[libvirt] [PATCH 22/24] qemu: Kill QEMU process if Prepare phase fails

Peter Krempa pkrempa at redhat.com
Fri Nov 13 15:21:53 UTC 2015


On Thu, Nov 12, 2015 at 19:37:24 +0100, Jiri Denemark wrote:
> Some failure paths in qemuMigrationPrepareAny forgot to kill the just
> started QEMU process. This patch fixes this by combining 'stop' and
> 'endjob' label into a new label 'stopjob'. This name was chosen to avoid
> confusion with the most common semantics of 'endjob'. Normally, 'endjob'
> is always called at the end of an API to stop the job we entered at the
> beginning. In qemuMigrationPrepareAny we only want to stop the job in
> failure path; on success we need to carry the job over to the Finish
> phase.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_migration.c | 31 ++++++++++++++++---------------
>  1 file changed, 16 insertions(+), 15 deletions(-)
> 

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151113/5776c460/attachment-0001.sig>


More information about the libvir-list mailing list