[libvirt] [PATCH v3 02/11] virt-admin: Introduce first working skeleton

[Martin Kletzander]

On Fri, Nov 06, 2015 at 12:46:17PM +0100, Erik Skultety wrote:
>This patch introduces virt-admin client which is based on virsh client,
>but had to reimplement several methods to meet virt-admin specific needs
>or remove unnecessary virsh specific logic.
>---
> .gitignore         |   1 +
> po/POTFILES.in     |   1 +
> tools/Makefile.am  |  26 ++-
> tools/virt-admin.c | 556 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> tools/virt-admin.h |  46 +++++
> 5 files changed, 628 insertions(+), 2 deletions(-)
> create mode 100644 tools/virt-admin.c
> create mode 100644 tools/virt-admin.h
>

I see you haven't added it to the specfile, which is good for now
(although we install it with make install), but we need to make sure
it is added there when we allow the admin interface.

>diff --git a/tools/virt-admin.c b/tools/virt-admin.c
>new file mode 100644
>index 0000000..ddfba91
>--- /dev/null
>+++ b/tools/virt-admin.c
[...]
>+static void
>+vshAdmDeinitTimer(int timer ATTRIBUTE_UNUSED, void *opaque ATTRIBUTE_UNUSED)
>+{
>+    /* nothing to be done here */
>+}
>+
>+/*
>+ * Deinitialize virt-admin
>+ */
>+static bool
>+vshAdmDeinit(vshControl *ctl)

No need for it to be bool, change it to void.

ACK with that changed.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151116/f4e1d8ac/attachment-0001.sig>