[libvirt] [PATCH] bhyve: monitor: do not override domain's privateData

Roman Bogorodskiy bogorodskiy at gmail.com
Tue Nov 17 10:09:37 UTC 2015


  Daniel P. Berrange wrote:

> On Wed, Nov 04, 2015 at 06:08:00PM +0300, Roman Bogorodskiy wrote:
> > Current monitor code overrides domain object's privateData, e.g.
> > in virBhyveProcessStart():
> > 
> >   vm->privateData = bhyveMonitorOpen(vm, driver);
> > 
> > where bhyveMonitorPtr() returns bhyveMonitorPtr.
> > 
> > This is not right thing to do, so make bhyveMonitorPtr
> > a part of the bhyveDomainObjPrivate struct and change related code
> > accordingly.
> > ---
> >  src/bhyve/bhyve_domain.h  |  4 ++++
> >  src/bhyve/bhyve_monitor.c | 36 +++++++++++++++++++-----------------
> >  src/bhyve/bhyve_process.c | 11 +++++++----
> >  3 files changed, 30 insertions(+), 21 deletions(-)
> 
> ACK

Pushed, thanks!

Roman Bogorodskiy




More information about the libvir-list mailing list