[libvirt] [PATCH 07/34] conf: Replace writes to def->maxvcpus with accessor

[John Ferlan]

On 11/20/2015 10:21 AM, Peter Krempa wrote:
> To support further refactors replace all write access to def->maxvcpus
> with a accessor function.
> ---
>  src/conf/domain_conf.c     | 18 ++++++++++++++++--
>  src/conf/domain_conf.h     |  2 ++
>  src/hyperv/hyperv_driver.c |  5 ++++-
>  src/libvirt_private.syms   |  1 +
>  src/libxl/libxl_driver.c   |  8 ++++++--
>  src/lxc/lxc_native.c       |  4 +++-
>  src/openvz/openvz_conf.c   |  4 +++-
>  src/openvz/openvz_driver.c |  5 ++++-
>  src/phyp/phyp_driver.c     |  4 +++-
>  src/qemu/qemu_command.c    |  9 +++++++--
>  src/qemu/qemu_driver.c     |  4 +++-
>  src/test/test_driver.c     |  4 +++-
>  src/vbox/vbox_common.c     | 11 +++++++++--
>  src/vmx/vmx.c              |  5 ++++-
>  src/vz/vz_sdk.c            |  4 +++-
>  src/xen/xm_internal.c      |  4 +++-
>  src/xenapi/xenapi_driver.c |  4 +++-
>  src/xenconfig/xen_common.c |  4 +++-
>  src/xenconfig/xen_sxpr.c   |  3 ++-
>  19 files changed, 82 insertions(+), 21 deletions(-)
> 

To be consistent with other uses (e.g. drivers, remote, libvirt-api), I
think it should be "Vcpus" rather than "VCpus".  The other options are
of course 'vCPUs' or "VCPUs", but they both look strange in/as API names.

The consistency is more for searching for vCPU related functionality and
since VCpu isn't used at all - introducing it just requires another way
to look-up names

John


>