[libvirt] [PATCH 17/34] qemu: Extract vCPU onlining/offlining via agent into a separate function

[John Ferlan]

On 11/20/2015 10:22 AM, Peter Krempa wrote:
> Separate the code so that qemuDomainSetVcpusFlags contains only code
> relevant to hardware hotplug/unplug.
> ---
>  src/qemu/qemu_driver.c | 137 +++++++++++++++++++++++++++----------------------
>  1 file changed, 77 insertions(+), 60 deletions(-)
> 


ACK 15, 16


> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 95b9ede..ab22c65 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -4853,6 +4853,59 @@ qemuDomainHotplugVcpus(virQEMUDriverPtr driver,
> 
> 

This function relies on qemuAgentUpdateCPUInfo to perform the maxvcpus
checks that wouldn't be made by refactoring this code here.  Perhaps
something worthy to note in the commit message (at least that's my
assumption based on reading the code).

ACK -

John

>  static int
> +qemuDomainSetVcpusAgent(virDomainObjPtr vm,
> +                        unsigned int nvcpus)
> +{

[...]