[libvirt] [PATCH 05/34] conf: Use local copy of maxvcpus in virDomainVcpuParse

[Peter Krempa]

On Mon, Nov 23, 2015 at 07:04:43 -0500, John Ferlan wrote:
> 
> 
> On 11/20/2015 10:21 AM, Peter Krempa wrote:
> > Use the local variable rather than getting it all the time from the
> > struct. This will simplify further refactors.
> > ---
> >  src/conf/domain_conf.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> > index 0ac7dbf..3c8a926 100644
> > --- a/src/conf/domain_conf.c
> > +++ b/src/conf/domain_conf.c
> > @@ -14664,13 +14664,13 @@ virDomainVcpuParse(virDomainDefPtr def,
> >              goto cleanup;
> >          }
> > 
> > -        def->vcpus = def->maxvcpus;
> > +        def->vcpus = maxvcpus;
> 
> There is no local maxvcpus (yet) and this breaks git bisect.
> 
> ACK 1-5 with this fixed

Indeed, this patch was moved a little bit too far. After putting it
behind "conf: Replace writes to def->maxvcpus with accessor" it compiles
just fine. I've pushed 1-4 and I'll push this after the mentioned patch
after fixing it.

Thanks

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151124/776ae996/attachment-0001.sig>