[libvirt] [PATCH] network: selectively disable -Wcast-align in virNetDevParseDadStatus

Ian Campbell ian.campbell at citrix.com
Thu Nov 26 15:10:12 UTC 2015

Commit 0f7436ca54c9 "network: wait for DAD to finish for bridge IPv6 addresses"
results in:

 CC     util/libvirt_util_la-virnetdevmacvlan.lo
util/virnetdev.c: In function 'virNetDevParseDadStatus':
util/virnetdev.c:1319:188: error: cast increases required alignment of target type [-Werror=cast-align]
util/virnetdev.c:1332:41: error: cast increases required alignment of target type [-Werror=cast-align]
util/virnetdev.c:1334:92: error: cast increases required alignment of target type [-Werror=cast-align]
cc1: all warnings being treated as errors

on at least ARM platforms.

The three macros involved (NLMSG_NEXT, IFA_RTA and RTA_NEXT) all appear to
correctly take care of alignment, therefore suppress Wcast-align around their

Signed-off-by: Ian Campbell <ian.campbell at citrix.com>
Cc: Maxim Perevedentsev <mperevedentsev at virtuozzo.com>
Cc: Laine Stump <laine at laine.org>
Cc: Dario Faggioli <dario.faggioli at citrix.com>
Cc: Jim Fehlig <jfehlig at suse.com>
 src/util/virnetdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index ade9afa..0bc809e 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -1316,7 +1316,10 @@ virNetDevParseDadStatus(struct nlmsghdr *nlh, int len,
     struct rtattr *rtattr_ptr;
     size_t i;
     struct in6_addr *addr;
     for (; NLMSG_OK(nlh, len); nlh = NLMSG_NEXT(nlh, len)) {
         if (NLMSG_PAYLOAD(nlh, 0) < sizeof(struct ifaddrmsg)) {
             /* Message without payload is the last one. */
@@ -1329,9 +1332,11 @@ virNetDevParseDadStatus(struct nlmsghdr *nlh, int len,
         ifaddrmsg_len = IFA_PAYLOAD(nlh);
         rtattr_ptr = (struct rtattr *) IFA_RTA(ifaddrmsg_ptr);
         for (; RTA_OK(rtattr_ptr, ifaddrmsg_len);
             rtattr_ptr = RTA_NEXT(rtattr_ptr, ifaddrmsg_len)) {
             if (RTA_PAYLOAD(rtattr_ptr) != sizeof(struct in6_addr)) {
                 /* No address: ignore. */

More information about the libvir-list mailing list