[libvirt] [PATCH 0/8] qemu: add support for virtio-input devices

[Gerd Hoffmann]

  Hi,

> I have only one thing to mention, but it's not in scope of this series, it's
> an existing behavior.  If you define a new guest with mouse/keyboard input
> device with bus!=ps2 and graphics is defined, then we always add implicit mouse
> and keyboard with bus=ps2 which leads to having two different mouses and
> keyboards defined for the guest.  We should probably update the code to not add
> any implicit mouse or keyboard if there is already one.

Adding ps/2 mouse + keyboard unconditionally makes sense (for x86) as
any qemu guest will actually have a ps/2 keybaord and ps/2 mouse (even
when started without graphics).  That is hard-coded in the machine type
init and can't be turned off.

cheers,
  Gerd