[libvirt] [PATCH] guest-agent-socket: don't generate default path to config XML

Martin Kletzander mkletzan at redhat.com
Mon Nov 30 14:40:40 UTC 2015

On Mon, Nov 30, 2015 at 12:18:41PM +0100, Pavel Hrdina wrote:
>On Mon, Nov 30, 2015 at 10:21:47AM +0100, Martin Kletzander wrote:
>> On Mon, Nov 30, 2015 at 09:35:39AM +0100, Pavel Hrdina wrote:
>> >While we started using for all unix sockets as default one common
>> >directory based on a guest name it introduced several issues, for example
>> >with renaming the guest or cloning it.  In general it's not entirely
>> >bad, but in this case it would be best to hide the auto-generated socket
>> >path from user and don't export it in the config XML.
>> >
>> In order to fix this also for domains that already exist, we should
>> ignore any socket paths starting with /var/lib/libvirt as those were
>> generated and users shouldn't explicitly specify them anyway.
>This is true only for domains created by system connection, for session
>connection it's $HOME/.local/libvirt/..., the question is, whether we care about
>session connection or not?

Sure we do, I only forgot about that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151130/247f62d4/attachment-0001.sig>

More information about the libvir-list mailing list