[libvirt] [PATCH] build: Create needed folders without dependency tracking

Martin Kletzander mkletzan at redhat.com
Mon Nov 30 14:41:52 UTC 2015

On Mon, Nov 30, 2015 at 03:35:55PM +0100, Peter Krempa wrote:
>On Mon, Nov 30, 2015 at 15:30:21 +0100, Martin Kletzander wrote:
>This is actually a v2 AFAIK.

The v1 was probably not from me, there were several attempts.

>> The parameter --disable-dependency-tracking is supposed to speed up
>> one-time build due to the fact that it disables some dependency
>> extractors that, apparently, take longer time to execute.  That is a
>> problem for code that is generated into builddir (especially some
>> specific subdirectory) because the directory it should be installed to
>> does not exists in VPATH and without the dependency tracking is not
>> created.  Generating such file hence fails with -ENOENT.  In order to
>> keep generating files into builddir instead of srcdir, we must create
>> the directory ourselves.  This should finally fix the problem that is
>> being fixed multiple times since its introduction in commit a9fe62037214
>> and let us continue with cleaning those parts of Makefiles that depend
>> on generating files into the srcdir rather than builddir as it should
>> be.
>Not sure whether the last sentence is worth to be in the commit message.

I'll remove it.

>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  src/Makefile.am | 1 +
>>  1 file changed, 1 insertion(+)
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index bcbee9de11d6..93b9c66662a1 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -181,6 +181,7 @@ MAINTAINERCLEANFILES += util/virkeymaps.h
>>  util/virkeymaps.h: $(srcdir)/util/keymaps.csv	\
>>  		$(srcdir)/util/virkeycode-mapgen.py
>> +	$(MKDIR_P) util/
>>  	$(AM_V_GEN)$(PYTHON) $(srcdir)/util/virkeycode-mapgen.py \
>>  	  <$(srcdir)/util/keymaps.csv >util/virkeymaps.h
>ACK, although I doubt that this is universal enough to allow doing the
>cleanup you are mentioning in the last sentence. This will fix only this
>one particular case, and for other serializations, other generated files
>may fail.

It won't help with any other file, sure, but we can then use this
pattern (pre-creating the directories), I should've explained myself
more clearly, will do next time.  Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151130/db3522ce/attachment-0001.sig>

More information about the libvir-list mailing list