[libvirt] [PATCH 3/8] storage: Prior to creating a volume, refresh the pool

John Ferlan jferlan at redhat.com
Fri Oct 2 13:41:33 UTC 2015


Although perhaps bordering on a don't do that type scenario, if
someone creates a volume in a pool outside of libvirt, then uses that
same name to create a volume in the pool via libvirt, then the creation
will fail and in some cases cause the same name volume to be deleted.

This patch will refresh the pool just prior to checking whether the
named volume exists prior to creating the volume in the pool. While
it's still possible to have a timing window to create a file after the
check - at least we tried.  At that point, someone is being malicious.

Signed-off-by: John Ferlan <jferlan at redhat.com>
 src/storage/storage_driver.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 7aaa060..ddf4405 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1796,6 +1796,15 @@ storageVolCreateXML(virStoragePoolPtr obj,
     if (virStorageVolCreateXMLEnsureACL(obj->conn, pool->def, voldef) < 0)
         goto cleanup;
+    /* While not perfect, refresh the list of volumes in the pool and
+     * then check that the incoming name isn't already in the pool.
+     */
+    if (backend->refreshPool) {
+        virStoragePoolObjClearVols(pool);
+        if (backend->refreshPool(obj->conn, pool) < 0)
+            goto cleanup;
+    }
     if (virStorageVolDefFindByName(pool, voldef->name)) {
                        _("'%s'"), voldef->name);

More information about the libvir-list mailing list