[libvirt] [PATCH] qemu: Align virQEMUCapsFlags members

Daniel P. Berrange berrange at redhat.com
Mon Oct 5 13:20:00 UTC 2015

On Mon, Oct 05, 2015 at 02:13:05PM +0200, Andrea Bolognani wrote:
> ---
> This pushes a lot of lines well beyond 80 columns, but then again some
> of the entries were already as long as 92 columns...
>  src/qemu/qemu_capabilities.h | 412 +++++++++++++++++++++----------------------
>  1 file changed, 205 insertions(+), 207 deletions(-)

I'm against any code which tries todo vertical alignment like
this. It always just ends up with us frequently creating patches
to redo the alignment as new longer-named items are added. This
in turn make cherry-picking backports painful.

If we're going to change anything, then I'd suggest we remove *all*
existing vertical from this code.

|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

More information about the libvir-list mailing list