[libvirt] [PATCH RESEND] Distribute only generated virkeymaps.h

Eric Blake eblake at redhat.com
Mon Oct 5 15:25:54 UTC 2015

On 10/05/2015 02:00 AM, Martin Kletzander wrote:
> On Mon, Oct 05, 2015 at 09:18:41AM +0200, Michal Privoznik wrote:
>> On 01.10.2015 14:39, Martin Kletzander wrote:
>>> We are distributing virkeymaps.h and all the tools needed to rebuild
>>> that file.  On top of that, we are generating that file into the
>>> $(srcdir) and that sometimes fails for me when trying to do make dist in
>>> VPATH on rawhide fedora.  And we don't clean the file when
>>> maintainer-clean make target is requested.
>>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>>> ---

>>> -EXTRA_DIST += $(srcdir)/util/virkeymaps.h $(srcdir)/util/keymaps.csv \
>>> -        $(srcdir)/util/virkeycode-mapgen.py
>>> -
>> I am afraid we can't do this. What if somebody wants to 'make dist'
>> from unpacked .tar.gz? They must have both .csv and .py files. So
>> you can't really drop them from here. What you can drop is .h file.
> Oh so that's probably what Daniel meant in the first proposition of
> this patch.  I misunderstood that.  OK, well, I think making dist from
> unpacked dist doesn't make much sense, but why would we block it,
> right?

In fact, 'make dist-check' does precisely that - it runs 'make dist'
from an unpacked dist, to make sure you didn't forget any source files
that were required to generate something that is not shipped
pre-generated.  So I agree that we have to ship the .csv and .py, and
only omit the .h.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151005/30173623/attachment-0001.sig>

More information about the libvir-list mailing list