[libvirt] [PATCH 3/5] qemu: Introduce flags in qemuMigrationCompleted

Peter Krempa pkrempa at redhat.com
Tue Oct 6 06:55:34 UTC 2015


On Mon, Oct 05, 2015 at 16:16:00 +0200, Jiri Denemark wrote:
> The function already has two bool parameters and we will need to add a
> new one. Let's switch to flags to make the callers readable.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_migration.c | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)
> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index ff9491c..1672323 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -2618,6 +2618,11 @@ qemuMigrationCheckJobStatus(virQEMUDriverPtr driver,
>  }
>  
>  
> +enum qemuMigrationCompletedFlags {
> +    QEMU_MIGRATION_COMPLETED_ABORT_ON_ERROR = (1 << 0),
> +    QEMU_MIGRATION_COMPLETED_CHECK_STORAGE  = (1 << 1),
> +};

I plan to do similar stuff with qemuMigrationIsAllowed and it's
parameters. :)

ACK,

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151006/cd55626f/attachment-0001.sig>


More information about the libvir-list mailing list