[libvirt] [PATCH] docs: domain: Show canonical pvspinlock XML
Martin Kletzander
mkletzan at redhat.com
Tue Oct 6 07:19:53 UTC 2015
On Mon, Oct 05, 2015 at 02:59:39PM -0400, Cole Robinson wrote:
>The example pvspinlock XML is:
>
> <pvspinlock/>
>
>While this is accepted by libvirt and works correctly, it's currently
>always output as a tristate like
>
> <pvspinlock state='on'/>
>
>So document that format instead
>---
> docs/formatdomain.html.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
We could also clean this and others to behave as apic, kvm, etc. by
doing s/ state='on'// on line 2209 in domain_conf.c. But whichever
one you choose, ACK.
>diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>index efa485c..c88b032 100644
>--- a/docs/formatdomain.html.in
>+++ b/docs/formatdomain.html.in
>@@ -1464,7 +1464,7 @@
> <kvm>
> <hidden state='on'/>
> </kvm>
>- <pvspinlock/>
>+ <pvspinlock state='on'/>
> <gic version='2'/>
>
> </features>
>--
>2.5.0
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151006/1aaa3c7f/attachment-0001.sig>
More information about the libvir-list
mailing list