[libvirt] [PATCH] conf: Remove <metadata> elements with no namespace

Peter Krempa pkrempa at redhat.com
Tue Oct 6 11:40:41 UTC 2015


On Mon, Oct 05, 2015 at 16:39:25 +0200, Michal Privoznik wrote:
> On 05.10.2015 10:56, Peter Krempa wrote:
> > Our docs state that subelements of <metadata> shall have a namespace
> > and the medatata APIs expect that too. To avoid inaccessible
> > <metadata> sub-elements, just remove those that don't conform to the
> > documentation.
> > 
> > Apart from adding the new condition this patch renames the function and
> > refactors the code flow to allow the changes.
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1245525
> > ---
> >  src/conf/domain_conf.c | 29 ++++++++++++++++++++++-------
> >  1 file changed, 22 insertions(+), 7 deletions(-)
> > 

...

> 
> ACK, but minding adding a simple test case?

Added test and pushed; Thanks.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151006/9a80b2b5/attachment-0001.sig>


More information about the libvir-list mailing list