[libvirt] [libvirt-python PATCH v2 18/23] improve usage of cleanup paths

John Ferlan jferlan at redhat.com
Tue Oct 6 23:43:40 UTC 2015

On 10/05/2015 03:57 AM, Pavel Hrdina wrote:
> This removes several code duplicates and also some unusual code structures.
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  libvirt-override.c | 264 +++++++++++++++++++++++++----------------------------
>  1 file changed, 126 insertions(+), 138 deletions(-)

ACK - I viewed diffs only - no git am.  Hopefully my eyes didn't glaze
over something.  BTW: The consumer I'd be more concerned with is not
virt-manager/install tools, rather RHEV type tools.  If it's possible to
get this to run through a virt-test or avacado test run prior to final
push that may be worthwhile for your sanity.  If not possible, at least
we have a few weeks to clean things up before next release cut!


More information about the libvir-list mailing list