[libvirt] [PATCH tck 2/6] nwfilter startup and shutdown delay

Daniel P. Berrange berrange at redhat.com
Thu Oct 8 09:19:52 UTC 2015

On Mon, Oct 05, 2015 at 05:18:39PM -0600, Mike Latimer wrote:
> When using larger test domains, additional time is required to ensure the
> domain is fully started and ready for the nwfilter tests. These same domains
> can also required a longer time to gracefully shutdown. This patch increases
> both timeouts, and modifies 220-no-ip-spoofing.t to match the startup changes
> introduced in libvirt-tck commit 83ef279c.
> Signed-off-by: Mike Latimer <mlatimer at suse.com>

IIRC, the main thing these tests all need is existance of SSH server,
so rather than having a fixed sleep, can we just poll on connect()
on the ssh port until we see that it is open. That way we sleep the
minimum required time.

|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

More information about the libvir-list mailing list