[libvirt] [PATCH] src: Generate virkeymaps.h into the correct directory

Andrea Bolognani abologna at redhat.com
Thu Oct 8 16:58:09 UTC 2015


On Thu, 2015-10-08 at 09:49 +0100, Daniel P. Berrange wrote:
> > -util/virkeymaps.h: $(srcdir)/util/keymaps.csv	\
> > +$(srcdir)/util/virkeymaps.h: $(srcdir)/util/keymaps.csv	\
> >  		$(srcdir)/util/virkeycode-mapgen.py
> >  	$(AM_V_GEN)$(PYTHON) $(srcdir)/util/virkeycode-mapgen.py \
> > -	  <$(srcdir)/util/keymaps.csv >util/virkeymaps.h
> > +	  <$(srcdir)/util/keymaps.csv >$(srcdir)/util/virkeymaps.h
> 
> If we're doing a VPATH build, surely we want to have the generated
> file go into $(builddir) not $(srcdir) ?

Definitely.

I've just sent a patch that tries to fix the same issue
with a different approach, please check it out.

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list