[libvirt] [PATCH] virJSONValueArraySize: return ssize_t

Ján Tomko jtomko at redhat.com
Fri Oct 9 11:01:12 UTC 2015


On Thu, Oct 08, 2015 at 10:33:01AM +0200, Michal Privoznik wrote:
> The internal representation of a JSON array counts the items in
> size_t. However, for some reason, when asking for the count it's
> reported as int. Firstly, we need the function to return a signed
> type as it's returning -1 on an error. But, not every system has
> integer the same size as size_t. Therefore, lets return ssize_t.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/locking/lock_daemon.c     |  2 +-
>  src/network/bridge_driver.c   |  2 +-
>  src/qemu/qemu_agent.c         | 12 ++++++------
>  src/qemu/qemu_monitor_json.c  | 28 ++++++++++++++--------------
>  src/rpc/virnetserver.c        |  2 +-
>  src/rpc/virnetserverservice.c |  2 +-
>  src/util/virjson.c            |  2 +-
>  src/util/virjson.h            |  2 +-
>  src/util/virlockspace.c       |  4 ++--
>  9 files changed, 28 insertions(+), 28 deletions(-)
> 

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151009/59c43d16/attachment-0001.sig>


More information about the libvir-list mailing list