[libvirt] [PATCH] src: Include $(builddir)/util in the header search path

Andrea Bolognani abologna at redhat.com
Fri Oct 9 11:11:44 UTC 2015


On Fri, 2015-10-09 at 10:15 +0200, Martin Kletzander wrote:
> Oh, byt he way, builddir is not a variable here (and not even
> anywhere
> else I believe), it's basically just the CWD (or PWD if you like), so
> we might need to do this on top:
> 
> diff --git i/src/Makefile.am w/src/Makefile.am
> index 01e816af88d1..d3fc29c03af6 100644
> --- i/src/Makefile.am
> +++ w/src/Makefile.am
> @@ -31,7 +31,7 @@ INCLUDES =	-I../gnulib/lib			
> 		\
>  		-I../include					
> \
>  		-I$(top_srcdir)/include				
> \
>  		-I$(srcdir)/util				\
> -		-I$(builddir)/util				\
> +		-Iutil						
> \
>  		-DIN_LIBVIRT					
> \
>  		-Dabs_topbuilddir="\"$(abs_topbuilddir)\""	\
>  		-Dabs_topsrcdir="\"$(abs_topsrcdir)\""		
> \

I used -I./util instead of -Iutil because it looks
cleaner to me, but yeah, using $(builddir) is not good
enough as older version of autoconf don't define it.

I've just sent the patch after testing it on CentOS 5,
please check it out.

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list