[libvirt] [PATCH] src: Remove $(builddir) usage

[Martin Kletzander]

On Fri, Oct 09, 2015 at 01:06:32PM +0200, Andrea Bolognani wrote:
>Commit 4e8032272f1704f7 used $(builddir) in the header search
>path to fix a build issue; however, $(builddir) is not defined
>by old autoconf versions such as the one available in CentOS 5,
>resulting in the following error:
>
>  cc1: error: /util: No such file or directory
>  make[3]: *** [libvirt_driver_la-fdstream.lo] Error 1
>
>Since $(builddir) is defined to always be '.', just use that
>value directly instead.
>---
> src/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/Makefile.am b/src/Makefile.am
>index 01e816a..d5dd9fb 100644
>--- a/src/Makefile.am
>+++ b/src/Makefile.am
>@@ -31,7 +31,7 @@ INCLUDES =	-I../gnulib/lib					\
> 		-I../include					\
> 		-I$(top_srcdir)/include				\
> 		-I$(srcdir)/util				\
>-		-I$(builddir)/util				\
>+		-I./util					\

You could've also define the builddir at the top of the makefile as we
do for abs_ variants of variables for older auto* which don't have
them.  Look at me, I'm saying it like there's a difference.  ACK
either way ;)  It would be nice to get rid of supporting old stuff
instead, though. </rant>

> 		-DIN_LIBVIRT					\
> 		-Dabs_topbuilddir="\"$(abs_topbuilddir)\""	\
> 		-Dabs_topsrcdir="\"$(abs_topsrcdir)\""		\
>--
>2.4.3
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151009/612b4e13/attachment-0001.sig>