[libvirt] [PATCH 02/12] storage: Remove duplicitous refreshVol in Sheepdog buildVol

John Ferlan jferlan at redhat.com
Fri Oct 9 13:34:01 UTC 2015


As of commit id '155ca616' a 'refreshVol' is called after a buildVol
succeeds in storageVolCreateXML, thus a volStorageBackendSheepdogRefreshVolInfo
call in virStorageBackendSheepdogBuildVol is no longer necessary.

Additionally, the 'conn' parameter becomes unused.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/storage/storage_backend_sheepdog.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c
index 69ba7836..1200813 100644
--- a/src/storage/storage_backend_sheepdog.c
+++ b/src/storage/storage_backend_sheepdog.c
@@ -257,7 +257,7 @@ virStorageBackendSheepdogCreateVol(virConnectPtr conn ATTRIBUTE_UNUSED,
 
 
 static int
-virStorageBackendSheepdogBuildVol(virConnectPtr conn,
+virStorageBackendSheepdogBuildVol(virConnectPtr conn ATTRIBUTE_UNUSED,
                                   virStoragePoolObjPtr pool,
                                   virStorageVolDefPtr vol,
                                   unsigned int flags)
@@ -279,9 +279,6 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn,
     if (virCommandRun(cmd, NULL) < 0)
         goto cleanup;
 
-    if (virStorageBackendSheepdogRefreshVol(conn, pool, vol) < 0)
-        goto cleanup;
-
     ret = 0;
  cleanup:
     virCommandFree(cmd);
-- 
2.1.0




More information about the libvir-list mailing list